search

atlas-aai / ratlas

Custom graphics and report generation for @atlas-aai
https://ratlas.netlify.app
28 stars 8 forks source link

Plotting vignette #21

Closed JeffreyCHoover closed 4 years ago

JeffreyCHoover commented 5 years ago

I have the first draft written for this vignette. I will attempt to get the Github checks passing before sending for your review.

JeffreyCHoover commented 4 years ago

@wjakethompson with all of the various projects going on at the moment, I know this is low priority, but the plotting vignette is ready for your content review. All of the github checks at least passed without the headache of last time!

wjakethompson commented 4 years ago

@JeffreyCHoover I took a pass to reorganized and change how the plots were defined (i.e., use scale_color_atlas() rather than scale_color_discrete(palette = palette_atlas)). Please take a pass to proof/suggest any changes!

wjakethompson commented 4 years ago

@JeffreyCHoover I need to go back through and resolve some merge conflicts, but have you had a chance to look at the content to see if you have any recommended changes?

JeffreyCHoover commented 4 years ago

@wjakethompson I did. Sorry it took me so long to get them pushed onto here! I had a few small wording/grammatical recommendations. Nothing major.

wjakethompson commented 4 years ago

I'm not too worried about it. Looks like just some issues with dependencies not loading correctly on R-devel. Once those packages are fixed downstream, this should be fine. I'm going to go ahead and merge this.

Closes #12.