Mhodgkin update code may2023

[shefmarkh]

This moves the usage of Gaudi variables to the more modern syntax where only one line of c++ defines the variable along with a default value and python side name. I think this makes the code much easier to read because you no longer have to flick between the header and source code file to see what these variables are and how they are defined.

Doing this I also found we had a number of unused variables which the compiler did not spot previously (because they were used in the constructor to assign a default value, but then never used elsewhere). So I have removed them.

I also found a bug whereby in the new CA config the calibration hit containers were never named and hence some of the calibration hit ntuple variables would not be filled presumably. Fixed with a default list of containers in the header file.

[shefmarkh]

Any comments on the changes @mswiatlo ?

[mswiatlo]

looks good, merged!