Properly handle the initialization of windows

[aadcg]

Instead of relying on this workaround, which has serious consequences, I suggest checking whether app.isReady() returns true.

From the docs:

[BrowserWindow] This module cannot be used until the ready event of the app module is emitted.

More info about the ready app event.

---

@jmercouris I'm just wondering: (1) were you unaware of this or (2) did you assume that the app would be ready?

[jmercouris]

I think you can wait indefinitely and it will never emit the "ready" signal. That is what I experienced on Qt. Not sure if it is different here. If you think this signal will work, perhaps it is the way.

[aadcg]

When you mention Qt, do you mean Nyxt's support for QtWebEngine or that Electron's binary relies on Qt for Linux?

[jmercouris]

I mean when in the past I was using QtWebEngine

[aadcg]

The signal works properly on Electron.

[jmercouris]

OK then :-)

[jmercouris]

Well, I've waited, and waited... and I've never seen this signal emitted. If we add a "isReady" listener, will it magically start being emitted? This by the way has led to bugs of javascript not being evaluated in the message buffer.

[aadcg]

One thing at a time @jmercouris. No information is better than bad information. This is not related to JS evaluation in the message buffer.

[jmercouris]

Except... it is! You shall see later today.

[aadcg]

If it would be, then I wouldn't be able to accomplish what you see below.

[jmercouris]

I DON'T BELIEVE I CANNOT BELIEVE

[aadcg]

Commit 372d81f0daccc2a207d257680c15ff63263375dd solved this issue.

We may have to return to this topic, but the issue needs to be re-framed.