search

atlas-engineer / cl-electron

Lisp Interface to Electron.
BSD 3-Clause "New" or "Revised" License
18 stars 2 forks source link

Synchronous javascript result. #28

Closed jmercouris closed 8 months ago

jmercouris commented 8 months ago

This allows the user to fetch the result of any arbitrary JavaScript computation sent to the server. Could be useful!

jmercouris commented 8 months ago

P.S. only look at the last three commits.

aadcg commented 8 months ago

P.S. only look at the last three commits.

Is there a specific reason why the PR can't be rebased on top of master?

jmercouris commented 8 months ago

P.S. only look at the last three commits.

Is there a specific reason why the PR can't be rebased on top of master?

No there isn't, it is just that I branched from the extend cl branch. I can do that now.

aadcg commented 8 months ago

No there isn't, it is just that I branched from the extend cl branch. I can do that now.

Yes, before opening a PR the branch should be rebased on top of master.

jmercouris commented 8 months ago

Opening new Pull Request.

aadcg commented 8 months ago

You could have also just fixed it in this PR without opening a new one by force pushing to it. Regardless, please don't forget to delete remote branches.