atlas-engineer / cl-electron

Lisp Interface to Electron.
BSD 3-Clause "New" or "Revised" License
18 stars 2 forks source link

Js synchronous error handling #31

Closed aadcg closed 8 months ago

aadcg commented 8 months ago

Fixes #30

The current draft doesn't fix the issue.

The error is raised, the user ignores it via the debugger but it is still a blocking operation.

jmercouris commented 8 months ago

that's why you wrap in a handler if you want it to continue

jmercouris commented 8 months ago

i can add a restart that does it

jmercouris commented 8 months ago

I have added two restarts. They are merged on master.

aadcg commented 8 months ago

@jmercouris the git history that you have merged to master is subpar is many ways and impacts the maintainability of the library. Please let me manage merging the PRs.

I've fixed it.