atlas-engineer / cl-electron

Lisp Interface to Electron.
BSD 3-Clause "New" or "Revised" License
18 stars 2 forks source link

Synchronous socket #34

Closed jmercouris closed 7 months ago

jmercouris commented 7 months ago

This adds A LOT of functionality to cl-electron. It particularly makes it possible for us to do flow-control within input events.

Note, there are not that many changes, there is only one large change that renames send-message-interface.

jmercouris commented 7 months ago

I will be testing on macOS tomorrow to ensure that this works properly. I will also rebase and tweak #35 as necessary in conjunction with this pull request.

jmercouris commented 7 months ago

Works on macOS! Now, I do have a branch that updates Nyxt to work with this latest set of changes. We'll have to update the submodule for cl-electron when we merge that branch.

jmercouris commented 7 months ago

The follow-up pull request is here: https://github.com/atlas-engineer/nyxt/pull/3381

jmercouris commented 7 months ago

Please also note that I will be working on a version of this change set that uses a C extension for Node.js to do synchronous socket reads rather than our sync-socket method. However, this does unblock us to do proper input handling!