search

atlas-engineer / nyxt

Nyxt - the hacker's browser.
https://nyxt-browser.com/
9.77k stars 409 forks source link

Auto refresh list-buffers buffer on changes #1302

Open Ambrevar opened 3 years ago

Ambrevar commented 3 years ago

A draft was submitted in #1035.

jmercouris commented 3 years ago

Why would we want auto refresh? I don't agree with this premise. Everything should only occur on-demand, in my opinion. Maybe I am too influenced by the behavior of emacs, but that is what I think.

Ambrevar commented 3 years ago

I think presenting the user with an outdated state of things is confusing. Emacs does not shine with its accessibility and I believe Nyxt should do better here.

jmercouris commented 3 years ago

Maybe. I'll need more time with this. Perhaps a practical implementation will change my mind.

aadcg commented 3 years ago

Maybe I am too influenced by the behavior of emacs, but that is what I think.

What happens when you kill a buffer from list-buffers or ibuffer in Emacs?

jmercouris commented 3 years ago

When I kill a buffer from this ibuffer, something happens, when it is killed from elsewhere, nothing happens. It would be no issue to wrap each delete button on list-buffers with (progn (delete-buffer xyz) (list-buffers)). I think Pierre is suggesting something different than what your original PR sought to achieve!

Ambrevar commented 3 years ago

I'm suggesting that the list-buffers buffer watches on (buffers *browser*) and automatically refreshes on every change.

aadcg commented 3 years ago

I see. No strong opinion. But we all agree that deleting buffers from list-buffers should update it.

PhilHudson commented 2 years ago

OT: How to 'fix' ibuffer:

(add-hook 'ibuffer-mode-hook #'ibuffer-auto-mode)

Useful now.

aadcg commented 10 months ago

To close this issue, a similar approach to what @MaxGyver83 did in #3199 should be taken.