atlas-engineer / nyxt

Nyxt - the hacker's browser.
https://nyxt-browser.com/
9.88k stars 414 forks source link

I get logged out of sites when re-opening Nyxt #1787

Closed anonimitoraf closed 2 years ago

anonimitoraf commented 3 years ago

Precise recipe to reproduce the issue

Is there a setting I have to enable for persistent sessions?

For website-specific issues: Can you reproduce this issue with Epiphany / GNOME Web (https://wiki.gnome.org/Apps/Web)? No

Information

ASDF version: 3.3.1 Critical dependencies: (/home/anonimito/common-lisp/nyxt/_build/submodules/cl-cffi-gtk/gtk/cl-cffi-gtk.asd /home/anonimito/common-lisp/nyxt/_build/quicklisp-client/dists/quicklisp/software/cl-gobject-introspection-20210124-git/cl-gobject-introspection.asd /home/anonimito/common-lisp/nyxt/_build/submodules/cl-webkit/webkit2/cl-webkit2.asd)

Quicklisp dist version: 2021-08-07 Quicklisp client version: 2020-01-04 Local project directories: (/home/anonimito/common-lisp/nyxt/_build/submodules/ /home/anonimito/common-lisp/nyxt/_build/quicklisp-client/local-projects/) Critical dependencies(#<SYSTEM cl-cffi-gtk / cl-cffi-gtk-20201220-git / quicklisp 2021-08-07>

<SYSTEM cl-gobject-introspection / cl-gobject-introspection-20210124-git / quicklisp 2021-08-07>

<SYSTEM cl-webkit2 / cl-webkit-20210807-git / quicklisp 2021-08-07>)

Guix version: 9875f9bca3976bf3576eab9be42164fde454597e

jmercouris commented 3 years ago

Could you please try with a more recent build? I believe this issue may have been at least /partially/ solved.

anonimitoraf commented 3 years ago

Hi @jmercouris

I pulled master and rebuilt. I still get logged out of youtube :( but I don't seem to be logged out from github anymore.

What were the issues before that you think might be causing this?

jmercouris commented 3 years ago

I believe it to be an issue with how we are handling cookie and data caches. As per YouTube I suspect they are doing something sneaky which we are blocking, either on accident, or on purpose.

anonimitoraf commented 3 years ago

Ah, I see. How do I disable all the ad-block-like modes?

anonimitoraf commented 3 years ago

Ok, with this, I don't get logged out anymore:

(define-configuration (web-buffer nosave-buffer)
  ((default-modes '())))

So I guess it is one of the blocker-like modes.

Seems to be both blocker-mode and reduce-tracking-mode

anonimitoraf commented 3 years ago

Actually, I've noticed that sometimes it logs me out. Sometimes it doesn't, intermittently.

I've disabled both blocker-mode and reduce-tracking-mode

This is my entire config:

(in-package :nyxt-user)

(defvar *swank-instance* (start-swank))

;; TODO Configure Emacs to fontify `def*'

;; Vim keybindings
(define-configuration buffer
  ((default-modes (append '(nyxt::vi-normal-mode) %slot-default%))))
(define-configuration prompt-buffer
  ((default-modes (append '(nyxt::vi-insert-mode) %slot-default%))))

;; Default modes
(define-configuration (web-buffer nosave-buffer)
  ((default-modes (append
                   '(auto-mode
                     ;; blocker-mode
                     ;; reduce-tracking-mode
                     ;; noimage-mode
                     ;; noscript-mode
                     ;; proxy-mode
                     force-https-mode)
                   %slot-default%))))
jbmestelan commented 3 years ago

I too get this behaviour, even with the default configuration. It is most noticeable with YouTube or GMail, from which I get disconnected on almost every restart. I do not think I noticed it on GitHub.

This is using the current Git master (99c8f81a).

Ambrevar commented 3 years ago

This could be fully fixed since https://github.com/atlas-engineer/nyxt/commit/fc39a0d7f68030fd3cbe2da03fa9304648176280. Can you people try master again?

jbmestelan commented 2 years ago

Yes, it appears to be fixed here. Thank you!

jbmestelan commented 2 years ago

Well, actually no, sorry: the issue still occurs (although much less frequently than before?). The issue tends to happen after Nyxt has exited in a crash.

Ambrevar commented 2 years ago

Fixed with #2050.