search

atlas-engineer / nyxt

Nyxt - the hacker's browser.
https://nyxt-browser.com/
9.85k stars 412 forks source link

Create a panel buffer that lists all keys that were pressed while using Nyxt #2037

Open pdelfino opened 2 years ago

pdelfino commented 2 years ago

This will be helpful for Nyxt Academy's videos. David Wilson from the YT channel System Crafters uses a similar thing for his tutorials while teaching Emacs. If my understanding is correct, he uses command-log-mode.

@edgar-vincent also suggested using something like this so that people could see which keys I was pressing.

aartaka commented 2 years ago

dispatch-input-event can be a good starting point there :)

Ambrevar commented 2 years ago

@pdelfino Minor nit: no need to prefix your issue name with "Feature request" if we are going to use the feature tag. That tag is more useful ;)

pdelfino commented 2 years ago

@pdelfino Minor nit: no need to prefix your issue name with "Feature request" if we are going to use the feature tag. That tag is more useful ;)

Yes. We can add tags. But normal users cannot. Sometimes, other random users used this pattern (maybe influenced by me) to create titles like this.

Examples: 1, 2, 3, 4, 5

This practice seems to have no downside. It might make the additions of labels easier (better for maintainers) and it might help with information retrieval - especially because we have multiple issues without any label. But I can stop if this bothers you... Maybe it looks ugly.

Ambrevar commented 2 years ago

It's OK for unprivileged users to prefix the title, I was just saying this for you since you can add tags, it helps keeing titles shorter.

pdelfino commented 2 years ago

It's OK for unprivileged users to prefix the title, I was just saying this for you since you can add tags, it helps keeing titles shorter.

I see and I was aware. I was just trying to help promoting the behavior among unprivileged users. But, I will keep the titles shorter from now on.

Ambrevar commented 2 years ago

Oh I see.

Then you gave me an idea: we can create a GitHub issue template for feature requests. By the way, maybe we could automatically tag them?

Ambrevar commented 2 years ago

Done in https://github.com/atlas-engineer/nyxt/commit/6401f0686b4cfcd778d21ab9ee1507102fc0ae88 !

I guess now there really is no need for the "Feature request:" prefix.

pdelfino commented 2 years ago

Oh I see. Then you gave me an idea: we can create a GitHub issue template for feature requests. By the way, maybe we could automatically tag them?

This is a great idea! Thanks :)

hendursaga commented 2 years ago

Not only the keys, but also the command, too, at least optionally!

guojing0 commented 2 years ago

I think the prompt buffer also keeps some kinds of history of the commands used by an user?

Ambrevar commented 2 years ago

Indeed, there is the history prompt buffer command accessible with M-h by default.

pdelfino commented 2 years ago

Indeed, there is the history prompt buffer command accessible with M-h by default.

Hi guys, there was a miscommunication. This is not exactly what I wanna do. Prompt-buffer history gives me: the strings inserted in the prompt buffer What I want: the commands executed in Nyxt (via keybinding or via prompt-buffer).

Also, the prompt-buffer history records things such as copy tile (notice the misspelling) which is close to the suggestion of copy-title. But, the history saves what was written not the command which was actually executed.

The needed information is stored somewhere else (in browser or current-windows instance, I suppose).