search

atlas-engineer / nyxt

Nyxt - the hacker's browser.
https://nyxt-browser.com/
9.88k stars 413 forks source link

Startup always stacks up a new `nyxt:help` page each time #2057

Open Ambrevar opened 2 years ago

Ambrevar commented 2 years ago

If you restore sessions and keep nyxt:help open, notice how the page keeps stacking up.

This was not a problem before Lisp URLs because internal buffers were not persisted in the session.

Now I suppose that we should update the startup procedure to not fire up a new nyxt:help page if one is already restored.

@aartaka What do you think?

aartaka commented 2 years ago

Yes, that feels most intuitive!

Ambrevar commented 2 years ago

Actually it's a bit more subtle: help should not re-create a buffer if it finds another one with the same name in help-mode. And the problem is this: restored buffers don't restore their modes!!! :/

See #2064.

aadcg commented 1 year ago

This one seems critical.

Ambrevar commented 1 year ago

And also pretty easy to fix. @aartaka @aadcg @jmercouris Anyone motivated to work on it?

Forget it, forgot this depends on #2064. I'll work on it then :p

aartaka commented 1 year ago

2627 could fix both #2064 and #1695, I believe.