Closed aadcg closed 1 year ago
@lansingthomas, any preliminary comment?
Problem 1 - too many lines before relevant information
name
field commands
and still communicate the same information. --> this enables us to remove the whole commands
line. See example image. I have also changed the background gray of the column titles (which might cause issues elsewhere).Problem 2 - I do not understand this yet. Let's talk about it over voice.
@lansingthomas you already helped. Ignore the rest of this discussion (you don't have enough background to follow it yet).
I was going to say that @lansingthomas's idea doesn't make much sense since he didn't understand the difference between sources and its attributes. But actually his observation is spot on. Why can't we have the first source attribute (the first column in prompt buffer) coincide with the source name? Is there a counter example in our codebase?
CC @aartaka.
Actually we can't do this. set-url-new-buffer
serves as a counter example.
Well, we actually can. With some attribute renaming.
@lansingthomas you already helped. Ignore the rest of this discussion (you don't have enough background to follow it yet).
It might still be related to Thomas' expertize, let'd not exclude him :P
Some terms so that we're on the same page:
I was going to say that @lansingthomas's idea doesn't make much sense since he didn't understand the difference between sources and its attributes. But actually his observation is spot on. Why can't we have the first source attribute (the first column in prompt buffer) coincide with the source name? Is there a counter example in our codebase?
We cannot, I'm guessing. Sources and their attributes are totally separate semantically, and should not be conflated unless we are willing to confuse the person using them. It's often the case that source name conicides with the first attribute name, but that's mostly because we tend to collect things into sources based a certain identity grouping that manifests itself both in source name and default/first attribute name. It's more than intuitive that if you collect books you'd have source named "Books" and the first attribute being simply "Book" or "Name".
So what we need it not hierarchy collapse, what we need is hierarchy highlighting. Like "This is a set of books, they belong to the same place, and here are individual books with their specific propreties" as an interface-induced takeaway. We can use some background that unites all of the suggestions for a source, and some visible nesting (instead of almost-invisible indentation) so that sources' names and attributes make much more sense.
Or we can have a good descriptive text for those and forget about tweaking interface in the places where only a good text could explaing things.
So what we need it not hierarchy collapse, what we need is hierarchy highlighting.
I agree with everything you say, but that doesn't seem to bring us any closer to de-cluttering the prompt buffer UI.
Perhaps you think that Problem 1 is not a problem?
Perhaps you think that Problem 1 is not a problem?
Indeed, I don't see it as a problem.
@lansingthomas after our session yesterday, you should be able to follow this discussion from top to bottom.
I've assigned you to this issue since you're iterating on a new specification for the prompt buffer.
The form of the prompt buffer (prompt area) is evolving. Let's try to take out the easy stuff first -- one at a time.
status bar
and the input buffer area
.modes
and other status bar
elements) -- the changes here accommodate the upcoming changes. status bar
with the input buffer area
. suggestions
, so we should connect them visually to communicate that connection.chamfer and bar along the right side
@aadcg @aartaka
All great ideas in my view @lansingthomas!
All good on my end!
Nice! We are aligned!
Now who wants to tackle this one?
@lansingthomas, sorry for the late reply. I have two complains here:
First, the area you're suggesting putting this X into is already used to list modes enabled in prompt buffer. Adding to or replacing those will likely be quite confusing.
Notice that @lansingthomas said:
further UI changes are in process (including modes and other status bar elements) -- the changes here accommodate the upcoming changes.
In my understanding, he and @jmercouris are re-thinking the way modes are displayed in the prompt buffer. Later, there will be further instructions on how to handle them.
I don't know what are their plans on that but, personally, I think that the modes enabled in the prompt buffer should be displayed in a radical different way than we do now.
Why two options at the same time? Either of those is clear enough and should be mostly sufficient as the way to close prompt buffer.
Do you mean that there would be a keyboard and mouse based way to close the prompt buffer? In my understanding that's exactly the goal: provide an additional and intuitive (mouse-based) way to close the prompt buffer.
Why two options at the same time? Either of those is clear enough and should be mostly sufficient as the way to close prompt buffer.
Do you mean that there would be a keyboard and mouse based way to close the prompt buffer? In my understanding that's exactly the goal: provide an additional and intuitive (mouse-based) way to close the prompt buffer.
No, what I meant is that there's too much mouse-based ways: the cross and the chevron, both doing the same thing. It feels redundant. I don't understand why we need both of those.
No, what I meant is that there's too much mouse-based ways: the cross and the chevron, both doing the same thing. It feels redundant. I don't understand why we need both of those.
I didn't interpret the proposed changes like that. The cross is displayed inside the chevron, but that's a single close button. @lansingthomas is my understanding accurate?
Ah chevron/chamfer, I confused those (*/∇\*)
I mean, why we need this-area-with-a-cross-on-the-top-of-prompt-buffer and this-small-triangle-in-the-bottom-right-corner, if they are doing the same thing?
I mean, why we need this-area-with-a-cross-on-the-top-of-prompt-buffer and this-small-triangle-in-the-bottom-right-corner, if they are doing the same thing?
I don't think they are doing the same thing, and I'd suggest going through @lansingthomas' proposal again!
The cross embedded in the chevron is a button to close the prompt buffer. The small triangle + the thin line on the right are aesthetical details that communicate continuity between the status buffer and the input area (I'm just rephrasing @lansingthomas' specification).
Yes, can confirm -- the hover-able area behind the X (within the chevron) should be the clickable exit.
update: @aartaka and I started to speak on video today but connection issues prevented meaningful exchange.
clickable exit
is functional for the entire pop-up (not just the input area)Just a heads up, I am working on this :-)
@lansingthomas could you re-read and conclude whether there is any actionable task left to squeeze from this thread?
@lansingthomas friendly ping :)
looks fantastic. Well done all.
When users invoke the prompt buffer, the suggestions are their main focus.
Between the input area and the suggestions, (in the most general case) there are two headers that draw the users' attention.
In other words, the suggestions start at the 4th line of the prompt buffer's UI. Given that it's the main focus, it takes some time to understand that those are the spotlight.
Obviously, the first line (input area) needs to be there.
Notice that the indentation between Source Header and Source Attributes Header hints at the fact that those Suggestions are part of that Source.
When looking at the Source Header, it's not obvious that its content refers to source names.
The interaction: