atlas-engineer / nyxt

Nyxt - the hacker's browser.
https://nyxt-browser.com/
9.78k stars 409 forks source link

Make message buffer more self-sufficient and discernible. #2719

Closed aartaka closed 11 months ago

aartaka commented 1 year ago

After #2713, we can move status buffer to the top of the view. Which exposes a problem: our message buffer, being a thin white/black strip at the bottom of the screen, is not distinctive enough to be discerned from the page content. We have to make it a bit more self-sufficient UI-wise. Several options there:

Clearly, the solution is actually a fusion of those three, not any single of those (although the idea with a contrasting border I believe to be quite sufficient and effective).

CC @lansingthomas, @aadcg, @jmercouris

aadcg commented 1 year ago

I changed my opinion a little bit. All I cared about was UI invariance. I.e., regardless of where the status buffer is drawn (top or bottom), there should be common properties between the two options. We decided not to port the invariants from the bottom status buffer to the top buffer. So anarchy reigns at this point :D

I have nothing interesting to share. I don't oppose anything. Except if you decide to change something about the default UI!

@aartaka, I'm saying that drawing a border around the message buffer is a viable solution when done conditionally (when the status buffer is at the top).

aartaka commented 1 year ago

So anarchy reigns at this point :D

Finally, a moment I long awaited \(T∇T)/

aadcg commented 1 year ago

I can't share your enthusiasm, but at least someone's happy.

lansingthomas commented 1 year ago

Hello computer enthusiasts! I want your feedback.

Please disregard the questions of the vintage groove (#2724), and the top status bar for this discussion.

What do you two think about coloring the message buffer like this image? @aartaka @aadcg

message buffer OPTION 1 (1)

Thank you!

aartaka commented 1 year ago

The color makes it stand out and rhyme with Nyxt interface elements (and I added it in a911f29c008dee02e79d7f217a4b4795ab0377ba), but what about websites we browse? How do we visually separate status and message buffers from the website content, @lansingthomas?

aadcg commented 1 year ago

@lansingthomas, a good proposal in my opinion! Nothing more to add.

lansingthomas commented 1 year ago

what about websites we browse? How do we visually separate status and message buffers from the website content, @lansingthomas?

I know we spoke about this today on call -- I will write it out here so we remember and for transparency in decision making.

Visual separation of the message buffer (status buffer, and web content)

  1. color similarity with input area creates continuity with known UI elements above, which communicates that the message buffer is an element (as opposed to part of the web-content)
  2. the color for the input area background is not actually in our theme (it is #eeeeee in light mode)
    • this is fine because the input area is functionally different from the rest of the UI.
    • connecting the input area and the message buffer is sensible because the message buffer is giving direct feedback for user inputs in the input area.

ongoing experiments

jmercouris commented 1 year ago

@lansingthomas Any updates on the border styles?

aadcg commented 11 months ago

Nothing to be done.