atlas-engineer / nyxt

Nyxt - the hacker's browser.

https://nyxt-browser.com/

9.8k stars 409 forks source link

Add hints alignment x slot #3302

Closed aadcg closed 8 months ago

aadcg commented 9 months ago

Description

A follow-up to #3226.

Fixes #3179. Fixes #3229.

Checklist:

[ ] Git branch state is mergable.
[ ] Changelog is up to date (via a separate commit).
[ ] New dependencies are accounted for.
[ ] Documentation is up to date.
[ ] Compilation and tests ((asdf:test-system :nyxt/gi-gtk))
- No new compilation warnings.
- Tests are sufficient.

MaxGyver83 commented 9 months ago

I have tested it and it works as expected.

A follow-up to https://github.com/atlas-engineer/nyxt/issues/3236.

I think this is a typo and you wanted to refer to PR #3226.

aadcg commented 9 months ago

@MaxGyver83 I have only rebased your work thus far. I'll add more commits soon and ping you for a review!

Thanks for the typo catch!

aadcg commented 8 months ago

I've refactored the work that @MaxGyver83 started in 1be02287e, while retaining the commit.

I believe that it meets the users needs in the most general possible way while maximizing maintainability on the developer's side.

The draft, as it stands, breaks backwards compatibility so it won't make it for the 3-series. I don't think this feature is a priority so that's OK.

Looking for a first round of reviews on this draft to ensure that we're all on the same page. CC @MaxGyver83 @jmercouris. Then I'll polish it and make it ready to be merged.

Screenshots:

2024_01_10_21:40:56-nyxt

2024_01_10_21:42:23-nyxt

jmercouris commented 8 months ago

Looks OK to me. Not sure what the magic number of -100 is, and why a font size of greater than 5 for that condition, but otherwise fine :-)

aadcg commented 8 months ago

Superseded by #3318 since the name of this branch is misleading.