atlas-engineer / nyxt

Nyxt - the hacker's browser.
https://nyxt-browser.com/
9.65k stars 404 forks source link

Drop `hint-mode`'s Shadow DOM support #3303

Closed aadcg closed 5 months ago

aadcg commented 6 months ago

Description

Fixes #3254

After a detailed examination, there is no fast way to re-write the feature in a timely fashion given the current priorities. On the other hand, the performance penalty introduced by the feature is rather severe and it is hurting the users. Issue #3295 hints at how it could be implemented.

Checklist:

jmercouris commented 5 months ago

Thanks Andre. I shall have a look!

jmercouris commented 5 months ago

I would have thought it would be enough to swap rqsa for qsa! In any case, it looks good. Thank you.

jmercouris commented 5 months ago

P.S. this is WAY faster.

aadcg commented 5 months ago

I would have thought it would be enough to swap rqsa for qsa! In any case, it looks good. Thank you.

You're missing rqs-nyxt-id. A closer look at b43ec712d450e64605e1a4a167ea6c992a3a036e (restricted to hint-mode) would clarify all that needs to be reverted in the context of this PR.