atlas-engineer / nyxt

Nyxt - the hacker's browser.

https://nyxt-browser.com/

9.65k stars 404 forks source link

Refactor `{enable,disable}-hook-handler` commands. #3310

Closed aadcg closed 5 months ago

aadcg commented 5 months ago

Description

These commands were suggested for deletion on #3297 but, on a closer look, I think they're in line with our goals.

I've revised the facilities.

I don't think it deserves a changelog entry.

Checklist:

[x] Git branch state is mergable.
[x] Changelog is up to date (via a separate commit).
[x] New dependencies are accounted for.
[x] Documentation is up to date.
[x] Compilation and tests ((asdf:test-system :nyxt/gi-gtk))
- No new compilation warnings.
- Tests are sufficient.

jmercouris commented 5 months ago

I'm not sure this is an improvement. Yes you are /technically/ removing code, but is there any real benefit? Also, do these /need/ to be commands? When would we ever use these?

aadcg commented 5 months ago

We'll discuss it later today.

jmercouris commented 5 months ago

OK!

aadcg commented 5 months ago

We agreed that these commands are helpful to add/remove hook handlers at run time.

The goal of refactoring the commands isn't to remove code but to improve maintainability.