atlas-engineer / nyxt

Nyxt - the hacker's browser.

https://nyxt-browser.com/

9.65k stars 404 forks source link

Delete html-string-p and related logic. #3312

Closed aadcg closed 5 months ago

aadcg commented 5 months ago

Description

I don't see the need for html-string-p in our API.

No need to for a changelog entry.

Checklist:

[x] Git branch state is mergable.
[x] Changelog is up to date (via a separate commit).
[x] New dependencies are accounted for.
[x] Documentation is up to date.
[x] Compilation and tests ((asdf:test-system :nyxt/gi-gtk))
- No new compilation warnings.
- Tests are sufficient.

jmercouris commented 5 months ago

I think the idea was that modes could generate things that are either HTML, or just strings, and somehow we would do different actions depending. I don't know. In any case, you are right. Not needed.