atlas-engineer / nyxt

Nyxt - the hacker's browser.

https://nyxt-browser.com/

9.64k stars 404 forks source link

Refactor scheme architecture #3348

Closed aadcg closed 3 months ago

aadcg commented 4 months ago

Description

A pre-requisite to https://github.com/atlas-engineer/nyxt/issues/2989, in the sense that it refactors the architecture of custom schemes in a renderer-agnostic fashion. It is a follow-up to #3341.

Checklist:

[x] Git branch state is mergable.
[x] Changelog is up to date (via a separate commit).
[x] New dependencies are accounted for.
[x] Documentation is up to date.
[x] Compilation and tests ((asdf:test-system :nyxt/gi-gtk))
- No new compilation warnings.
- Tests are sufficient.

jmercouris commented 4 months ago

I have been looking at this, and haven't found any problem yet. I will continue to review it.

jmercouris commented 3 months ago

The manual command works, but not when clicked from the button on the home page.

It even works if I set the url to nyxt:manual from the home page.

home page == nyxt:new

jmercouris commented 3 months ago

If I click on a symbol within a code block, it also does not work. I am brought again to the debugger.

aadcg commented 3 months ago

The manual command works, but not when clicked from the button on the home page.

If I click on a symbol within a code block, it also does not work. I am brought again to the debugger.

I've seen these bugs before, I'll fix those.

aadcg commented 3 months ago

@jmercouris should be fixed, please test it.

jmercouris commented 3 months ago

Will do!

jmercouris commented 3 months ago

No problems found :-)