atlas-engineer / nyxt

Nyxt - the hacker's browser.

https://nyxt-browser.com/

9.64k stars 404 forks source link

Input dispatch simplify #3350

Closed jmercouris closed 3 months ago

jmercouris commented 4 months ago

Description

Simplifies input dispatch. Makes it so that the input dispatch will return t/nil depending on whether the keypress event should be consumed by Lisp. Simplifies the creation of renderers.

Checklist:

[x] Git branch state is mergable.
[X] Changelog is up to date (via a separate commit).
[X] New dependencies are accounted for.
[X] Documentation is up to date.
[X] Compilation and tests ((asdf:test-system :nyxt/gi-gtk))
- No new compilation warnings.
- Tests are sufficient.

aadcg commented 3 months ago

Overall, this is a very welcomed change. I need to look a bit more closely and to see if I can find any regressions.