atlas-engineer / nyxt

Nyxt - the hacker's browser.

https://nyxt-browser.com/

9.64k stars 404 forks source link

Refactor set url #3351

Closed aadcg closed 3 months ago

aadcg commented 4 months ago

Description

Fixes #3349

The CI fails but it is unrelated to this PR.

Checklist:

[x] Git branch state is mergable.
[x] Changelog is up to date (via a separate commit).
[x] New dependencies are accounted for.
[x] Documentation is up to date.
[x] Compilation and tests ((asdf:test-system :nyxt/gi-gtk))
- No new compilation warnings.
- Tests are sufficient.

aadcg commented 3 months ago

@fictitiousexistence and @odanoburu, if you have the chance to review this PR, feedback is welcome. Thanks.

odanoburu commented 3 months ago

No freezes here. Thank you @aadcg !

jmercouris commented 3 months ago

I couldn't get it to freeze!

aadcg commented 3 months ago

Obrigado @odanoburu and @jmercouris!

fictitiousexistence commented 3 months ago

@aadcg Just got around to testing. Seems to be functioning properly again. Thanks!

fictitiousexistence commented 2 months ago

@aadcg After using this for about a month I started to realize that using a direct ip instead of a hostname will take you to search results for that ip instead of trying http/https. An example ip: 146.190.62.39 (httpforever.com).

Also it seems to go to search results if you enter a full url with a path ex: httpforever.com/favicon.ico.

Thanks.

aadcg commented 2 months ago

@fictitiousexistence you are correct, but this has been the behavior all along. In other others, the topic you're raising is unrelated to this PR and I'd suggest opening an issue.

For a URL to be interpreted as an IP you need to input e.g. http://192.168.0.1. Note that in Firefox, while possible to input 192.168.0.1, it is resolved internally to http://192.168.0.1 (to prove it, copy from the address bar). It should be easy to implement this DWIM behavior in Nyxt.