atlas-engineer / nyxt

Nyxt - the hacker's browser.

https://nyxt-browser.com/

9.64k stars 404 forks source link

Update makefile: default installation paths #3357

Closed t-braswell closed 3 months ago

t-braswell commented 3 months ago

Description

added default values of DESTDIR, PREFIX and NASDF_SOURCE_PATH. makefile now runs without need to edit.

Checklist:

[X ] Git branch state is mergable.
[ X] Changelog is up to date (via a separate commit).
[ X] New dependencies are accounted for.
[ X] Documentation is up to date.
[ X] Compilation and tests ((asdf:test-system :nyxt/gi-gtk))
- No new compilation warnings.
- Tests are sufficient.

aadcg commented 3 months ago

@t-braswell thanks for the PR, but I'm afraid it doesn't solve any issue. If you want to install Nyxt with those parameters, then run make DESTDIR=/usr/local/bin/ PREFIX=/usr/local/bin/ install.

Note that NASDF_SOURCE_PATH, when omitted, is computed based on PREFIX.

t-braswell commented 3 months ago

can we make a note of that default computation, and possibly set default values?

aadcg commented 3 months ago

can we make a note of that default computation, and possibly set default values?

See ce4618e1c. Does it seem reasonable?

t-braswell commented 3 months ago

i like it. main reason to ask was because i didnt know what the default installation was when i tried to compile.

aadcg commented 3 months ago

Thanks @t-braswell. Please open an issue if you have any further questions about the manual installation process.