Closed brosasaki closed 5 days ago
EDIT: I’ve found that setting search-auto-complete-p nil
in the context-buffer
configuration is a work-around for the issue, for now.
@brosasaki thanks for reporting.
It seems that after 36589e3d622c510df40baf6e4fd8b0bffa644a71, 8b00a2f8cf839c1dfe007b84b2df80456afc39a4 and 14dac1e88 we still got it wrong. @shamazmazum, @jmercouris can you reproduce the reported issue?
It may be that the feature was poorly designed from its inception (from 8887a7e64b6c281e74a163835b865d92fdd9dd4c) and we're trying to fix a house made of sand.
We should probably do it from scratch and set search-auto-complete-p
to nil
by default in the mean time.
Maybe. I'll have to look. In the interim, I'm more than happy to default to nil for this option.
@aadcg I do not have this issue because I run nyxt with
(define-configuration context-buffer
((search-always-auto-complete-p nil)))
in the config :) I'll test it without this setting later. Not sure if search-auto-complete-p
is the same as search-always-auto-complete-p
.
I cannot reproduce it. Navigation seems to be working fine and nyxt does not hang up.
@shamazmazum did you test against the master branch or the 3.11.6 tag? Note that your PR #3385 will be part the next release. Regardless, it shouldn't make any difference since, if I recall correctly, the changes are orthogonal to the issue at hand.
I can't reproduce it as well. We should resort to the suggestion above if the issue is reproducible.
@aadcg I tested against 3.11.6, but with those changes cherry-picked.
Although not reproducible, let's keep this piece of information in the back of our heads.
Should anyone experience hangs, they could follow the tip and set search-auto-complete
to nil
.
Describe the bug Nyxt hangs consistently on URL/Search prompt in certain states Precise recipe to reproduce the issue Browse to different websites using
C-l
orM-l
. After visiting 2-5 sites, Nyxt will hang while inputting the url/query and will have to be killed withpkill -1
. Restarting Nyxt will restore the state, and will no longer be hanged, but trying again to input a url will hang after an inconsistent number of characters input. Killing the buffer fixes the issue, even if you return to the same website. I can provide the VM image or other state data on request.Information
show-system-information
:ASDF version: 3.3.5 ASDF registries: (NYXT-SOURCE-REGISTRY ENVIRONMENT-SOURCE-REGISTRY USER-SOURCE-REGISTRY USER-SOURCE-REGISTRY-DIRECTORY DEFAULT-USER-SOURCE-REGISTRY SYSTEM-SOURCE-REGISTRY SYSTEM-SOURCE-REGISTRY-DIRECTORY DEFAULT-SYSTEM-SOURCE-REGISTRY) Critical dependencies: (/gnu/store/q3cxhqk68mqj5n5g2x3dpl2f4la5vzy2-sbcl-cl-cffi-gtk-3.8.8-3.1700fe6/share/common-lisp/sbcl/cl-cffi-gtk/gtk/cl-cffi-gtk.asd /gnu/store/5953s2h5cpb7llq2ip3zmv4yk6yxm6zn-cl-gobject-introspection-0.3-3.83beec4/share/common-lisp/source/cl-gobject-introspection/cl-gobject-introspection.asd /gnu/store/lm2nh1cz60jgkx4anzf3bk93cyn3azld-sbcl-cl-webkit-3.5.10/share/common-lisp/sbcl/cl-webkit/webkit2/cl-webkit2.asd)
Guix version:
Nyxt version 3.11.6