Closed shamazmazum closed 3 weeks ago
Oops, I am sorry. Gmail opens fine, but search queries which contain spaces are now causing an endless loop. Looking for another solution.
@shamazmazum I took a brief look at the recent changes. Would it make sense to add a variant of quri:url-encode-params
or refactor it in such a way that percent-encoding is optional? I am a maintainer of quri
.
@aadcg Where to put a new entry in the changelog? 4.0.0? 3.11.7? What is the next release? 3.11.7, as I presume.
Few comments on code:
url-filter-params
is good at least for debugging. It does not require a string to be wrapped in two layers of abstraction.I agree with the rest.
@shamazmazum 3.11.7, thanks.
Your argumentation makes sense.
@shamazmazum I took a brief look at the recent changes. Would it make sense to add a variant of
quri:url-encode-params
or refactor it in such a way that percent-encoding is optional? I am a maintainer ofquri
.
Yes, it would be better. I'll take a look at it. It can take some time, though :)
Yes, it would be better. I'll take a look at it. It can take some time, though :)
No pressure! Thanks.
OK, I've added a PR to quri, waiting for approval. After it is merged, I'll modify this PR to use quri for correct handling of parameters.
Sounds good @shamazmazum, thanks.
I think, it's done :)
@shamazmazum I've merged with PR with minor changes via commit 6a7afab14, thanks!
This PR fixes #3402. Fix
strip-tracking-parameters
which was damaging some kind of URLs.