atlas-engineer / nyxt

Nyxt - the hacker's browser.
https://nyxt-browser.com/
9.64k stars 404 forks source link

Fix inability to open Gmail when using reduce-tracking-mode. #3403

Closed shamazmazum closed 3 weeks ago

shamazmazum commented 1 month ago

This PR fixes #3402. Fix strip-tracking-parameters which was damaging some kind of URLs.

shamazmazum commented 1 month ago

Oops, I am sorry. Gmail opens fine, but search queries which contain spaces are now causing an endless loop. Looking for another solution.

aadcg commented 1 month ago

@shamazmazum I took a brief look at the recent changes. Would it make sense to add a variant of quri:url-encode-params or refactor it in such a way that percent-encoding is optional? I am a maintainer of quri.

shamazmazum commented 1 month ago

@aadcg Where to put a new entry in the changelog? 4.0.0? 3.11.7? What is the next release? 3.11.7, as I presume.

Few comments on code:

I agree with the rest.

aadcg commented 1 month ago

@shamazmazum 3.11.7, thanks.

Your argumentation makes sense.

shamazmazum commented 1 month ago

@shamazmazum I took a brief look at the recent changes. Would it make sense to add a variant of quri:url-encode-params or refactor it in such a way that percent-encoding is optional? I am a maintainer of quri.

Yes, it would be better. I'll take a look at it. It can take some time, though :)

aadcg commented 1 month ago

Yes, it would be better. I'll take a look at it. It can take some time, though :)

No pressure! Thanks.

shamazmazum commented 4 weeks ago

OK, I've added a PR to quri, waiting for approval. After it is merged, I'll modify this PR to use quri for correct handling of parameters.

aadcg commented 4 weeks ago

Sounds good @shamazmazum, thanks.

shamazmazum commented 3 weeks ago

I think, it's done :)

aadcg commented 3 weeks ago

@shamazmazum I've merged with PR with minor changes via commit 6a7afab14, thanks!