search

atlas-engineer / nyxt

Nyxt - the hacker's browser.
https://nyxt-browser.com/
9.64k stars 404 forks source link

Invalid Git submodule #3405

Closed oblivikun closed 1 month ago

oblivikun commented 1 month ago

Describe the bug There is a submodule specified that the url does not exist ` [submodule "_build/devel"] path = _build/devel url =https://gitlab.common-lisp.net/misc-extensions/devel.git

` Precise recipe to reproduce the issue git clone --recurse-submodules https://github.com/atlas-engineer/nyxt For website-specific issues: Can you reproduce this issue with Epiphany / GNOME Web (https://wiki.gnome.org/Apps/Web)?

Information

Output when started from a shell

aadcg commented 1 month ago

@oblivikun thanks for reporting.

The library is now hosted elsewhere. Fixed via 832174d32.

aadcg commented 1 month ago

This is not yet fixed because some dependencies (such as nfiles) also depend on the library and register it as a git submodule. AFAIK, there's no way to run git clone --recurse-submodules ... exclusively on direct submodules.

While we could fix the URL everywhere, there is no good reason for these CL libraries (maintained by @atlas-engineer/atlas) to register their dependencies as git submodules. It enables running CI routines in their own repositories, which isn't wise from a maintenance perspective since that env must be kept with sync with that of Nyxt. It would wiser to run the test suite of those libraries within Nyxt's CI.

I'll take this opportunity to fix the long standing issue mentioned above.