search

atlas-engineer / nyxt

Nyxt - the hacker's browser.
https://nyxt-browser.com/
9.64k stars 404 forks source link

Function imports in cl-gobject-introspection & fset are incompatible with SBCL 2.4.5 #3408

Closed durrendal closed 5 days ago

durrendal commented 3 weeks ago

While updating the nyxt package for Alpine I ran into a couple of small issues. It looks like two of the libs used by nyxt are importing functions from sb-ext that have been moved to sb-int. If it's meaningful we're building nyxt 3.11.7 against SBCL 2.4.5.

Specifically this seems to be affecting:

The patches we're using to fix those build errors can be found here: https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/67055/diffs

cl-gobject-introspection has actually made the same change upstream a couple of weeks ago, but it doesn't look like they've release a new version with that fix from what I can tell? https://github.com/andy128k/cl-gobject-introspection/issues/100

fset hasn't made any changes at all.

bubbleguuum commented 3 weeks ago

Confirming same issue updating openSUSE Tumbleweed package with SBCL 2.4.5. Will use the patches in the meantime, thanks !

aadcg commented 3 weeks ago

@durrendal thanks for reporting and for the patches.

I've noticed it too when releasing on Flathub, therefore I built against SBCL 2.4.4. SBCL is released on a monthly basis so it's ok to be one release behind.

aadcg commented 5 days ago

Both issues are now solved. fset released 1.4.0 which ships a fix.

Thanks.