search

atlas-engineer / nyxt

Nyxt - the hacker's browser.
https://nyxt-browser.com/
9.79k stars 409 forks source link

Replace `extended-command-source` by separate command akin to `eval-expression` #3463

Open aadcg opened 1 month ago

aadcg commented 1 month ago

It's not sensible that execute-command also evaluates sexps. Instead, there should be a separate command for that purpose.

Not to mention that the logic behind extended-command-source (its prompter:filter-preprocessor) is an abomination.

divyaranjan1905 commented 1 month ago

Hello, I'm planning to contribute to this browser. I've been using it on and off for the last few years. I'd like to be assigned for this issue, and @aadcg can you describe in a bit more detail where to look (file in the source) for the specific issue and what the new command must also do?

aadcg commented 1 month ago

Hi @divyaranjan1905! Thank you for the interest.

can you describe in a bit more detail where to look (file in the source)

See source/command-commands.lisp.

what the new command must also do?

As described in the issue's title, inspiration can be taken from Emacs' eval-expression. There's no need to implement completion or other fancy things.

Let me know if this helps.