`quit-prompt-buffer` and `prompt-buffer-canceled` naming inconsistency?

[aartaka]

Since atlas-engineer/nyxt#2655, the function that used to be called cancel-input is called quit-prompt-buffer. But the condition that used to be related to this function is still called prompt-buffer-canceled, which may confuse someone using Nyxt's prompt buffer.

I see two ways out of this inconsistency:

1. Return the cancel as a verb to relate to this operation. Thus, have cancel-prompt-buffer or something similar.
2. Rename prompt-buffer-canceled to refer to "quit"-ting.

I am personally in favor of (1), because

• I like how clear and actionable "cancel" is: quitting is much more neutral of an action that does not fully express the unwillingness to terminate the prompt normally, while cancelling is doing something against the expected scenario and bailing out of the prompt altogether.
• It's more backwards-compatible and breaks less user configs with no clear way to fix them.

[aadcg]

No strong opinion.

[Ambrevar]

No strong opinion either, however slightly leaning towards being conservative with the previous naming, so option (1).

[lansingthomas]

I like cancel. canceling is stopping something in progress, while quitting is like leaving. And there are other similarly named things with quit.