atlas-viewer / atlas

Main repository for Atlas viewer
https://atlas-viewer-storybook.netlify.app/
MIT License
5 stars 3 forks source link

allow for images with a static preset to scroll #26

Closed abrin closed 6 months ago

abrin commented 6 months ago

outlining a potential solution for https://github.com/digirati-co-uk/iiif-canvas-panel/issues/232 based on my very basic understanding of the code. Apologies if I've messed things up.

The touch-action: none css property is set on the .atlas class indescriminantly, causing it to consume all touch events. For cases where Atlas is intended to ‘own’ those events that’s fine. But, in the static mode, the window/document should own those events.

By exposing the render preset as a class, we can use that as a selector, and thus return the touch-events property to the default by setting it to inherit

codesandbox-ci[bot] commented 6 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

stephenwf commented 6 months ago

Thanks! Sorry I missed the notification. 👍

stephenwf commented 6 months ago

That's @atlas-viewer/atlas@2.0.6 published with the fix