search

atlas-viewer / atlas

Main repository for Atlas viewer
https://atlas-viewer-storybook.netlify.app/
MIT License
5 stars 4 forks source link

fix imagesPending assignment #51

Closed danieltbrennan closed 5 months ago

danieltbrennan commented 5 months ago

@stephenwf I looked at the issue in the CanvasPanel update and immediately realized that I had failed to push this commit at the end - this should be Math.max otherwise imagesPending is always going to be 0 and nothing will render.

codesandbox-ci[bot] commented 5 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

stephenwf commented 5 months ago

Oh, that's my fault! https://github.com/atlas-viewer/atlas/pull/50#issuecomment-2099103673

I'll get this merged 👍