atlasacademy / fgo-game-data-api

HTTP API for FGO game data. Transform the raw game data into something a bit more manageable.
https://api.atlasacademy.io
GNU Affero General Public License v3.0
80 stars 12 forks source link

Some servant's battle voices are not correct #28

Open squaresmile opened 2 years ago

squaresmile commented 2 years ago

Some servant's battle voices are not correct:

ArtichaTM commented 6 months ago

Katou "Black Kite" Danzo: NP 1

ArtichaTM commented 6 months ago

Mash lost her "Lord Camelot!" in NP audio

ArtichaTM commented 6 months ago

Anne Bonny & Mary Read has broken Command Card 1/2/3 and Noble Phantasm Card 1, that for some reason duplicated with different subtitles + unplayable/undownloadable

IVoyagerII commented 6 months ago

King Hassan Extra attack 3 line (updated earlier today) doesn't play on Atlas and doesn't appear in the explorer

ArtichaTM commented 6 months ago

Found what's broken in Nero (Caster). Take a look into Ushiwakamaru Psychedelic Wandering Tales costume (index 11)

Ushiwakamaru json ![image](https://github.com/atlasacademy/fgo-game-data-api/assets/46131671/4024bfaa-83ab-4afe-a762-9220a6ca845c)

voicesLines[0]["id"] starts with 11, like any other audio assets. Before "_" u can find ascension (id of ascension or costume). And I relied on this a lot. However for some weird reason Nero (Caster) having id 0, while actually it's a voice line of costume!

Nero (Caster) json ![image](https://github.com/atlasacademy/fgo-game-data-api/assets/46131671/0f20b25c-0bae-4458-af39-c2ea06d94e06)

Not all voice_lines bugged like that. Only:

{name} ({ascension}) points to one path {acension}\{category}\{overwrite before "-"}\{overwrite after"-"}
About the Event (Second Block) 1 (0) points to one path Asc0\EventReward\The Return of Nero Fest\Autumn 2019 1
Prize Roulette Voice 6 (0)           points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 17
About the Event (Second Block) 5 (0) points to one path Asc0\EventReward\The Return of Nero Fest\Autumn 2019 5
About the Event (Second Block) 4 (0) points to one path Asc0\EventReward\The Return of Nero Fest\Autumn 2019 4
About the Event (Second Block) 3 (0) points to one path Asc0\EventReward\The Return of Nero Fest\Autumn 2019 3
Prize Roulette Voice 9 (0)           points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 19
Prize Roulette Voice 12 (0)          points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 22
Shop Voice (Second Block) 2 (0)      points to one path Asc0\EventShop\The Return of Nero Fest\Autumn 2019 8
Prize Roulette Voice 2 (0)           points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 13
Prize Roulette Voice 10 (0)          points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 20
Shop Voice (Second Block) 5 (0)      points to one path Asc0\EventShop\The Return of Nero Fest\Autumn 2019 11
Prize Roulette Voice 5 (0)           points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 16
Shop Voice (Second Block) 4 (0)      points to one path Asc0\EventShop\The Return of Nero Fest\Autumn 2019 10
About the Event (Second Block) 6 (0) points to one path Asc0\EventReward\The Return of Nero Fest\Autumn 2019 6
Shop Voice (Second Block) 1 (0)      points to one path Asc0\EventShop\The Return of Nero Fest\Autumn 2019 7
Shop Voice (Second Block) 3 (0)      points to one path Asc0\EventShop\The Return of Nero Fest\Autumn 2019 9
Prize Roulette Voice 11 (0)          points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 21
Prize Roulette Voice 4 (0)           points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 15
Shop Voice (Second Block) 11 (0)     points to one path Asc0\EventShop\The Return of Nero Fest\Autumn 2019 12
About the Event (Second Block) 2 (0) points to one path Asc0\EventReward\The Return of Nero Fest\Autumn 2019 2
Prize Roulette Voice 3 (0)           points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 14
Prize Roulette Voice 8 (0)           points to one path Asc0\BoxGachaTalk\The Return of Nero Fest\Autumn 2019 18
ArtichaTM commented 6 months ago

Ishtar has 2 voice lines for default summon and one as Event Reward. For some reason, default voice lines have same type in parent dictionary and in voice line dict, but for event reward svtVoiceType = "firstGet"

Correct type ![image](https://github.com/atlasacademy/fgo-game-data-api/assets/46131671/b3cb5b68-2944-4ff1-9725-f2bdad3a692b)
Wrong type ![image](https://github.com/atlasacademy/fgo-game-data-api/assets/46131671/13ffc3c2-cc26-4d3b-87a5-e8b927c48beb)
ArtichaTM commented 6 months ago

Nitocris (Assassin). What is this? Ascension 1-4. Undownloadable, only names left

Screenshot ![image](https://github.com/atlasacademy/fgo-game-data-api/assets/46131671/4ddb0f9c-af66-48cb-b710-a7d59234045f)
ArtichaTM commented 6 months ago

Ivan the Terrible has NP lines in Battle (while usually they in "Treasure Device" section)

ArtichaTM commented 6 months ago

Super Bunyan has broken voice line in absolutely new voice line category. Unplayable, undownloadable, untranslated

Image ![image](https://github.com/atlasacademy/fgo-game-data-api/assets/46131671/f1c0c71f-db97-4480-8a74-f5b42226d632)

Mary Anning has broken voice line in new voice line category. Unplayable, undownloadable, without translation

Image ![image](https://github.com/atlasacademy/fgo-game-data-api/assets/46131671/e027b02b-f6bd-4dc5-b1e8-180c7e7e6412)
squaresmile commented 2 months ago

I added a lot of the missing audio files so it should be much more complete now. However some lines are not complete on the db/api.

https://apps.atlasacademy.io/db/NA/servant/142/voices Ishtar NP lines are missing An Gal Ta Ki Gal Šè and またの名を Jabal Hamrin Breaker The game has them somehow They are in https://static.atlasacademy.io/NA/Audio/NoblePhantasm_202000/NP_202000_1.mp3 and https://static.atlasacademy.io/NA/Audio/NoblePhantasm_202000/NP_202000_8.mp3 but dunno how to find them in master data