atlasmap-attic / atlasmap-runtime

AtlasMap runtime engine and design time services

http://atlasmap.io

Other

3 stars 8 forks source link

#216 Update DefaultFieldActionService to support overloaded FieldAction names #250

Closed mattrpav closed 6 years ago

mattrpav commented 6 years ago

216 Update DefaultFieldActionService to support overloaded FieldAction names

First pass of implementation, modifying the lookup of FieldActions to use the sourceType as a hint when multiple FieldActions exist with the same name

igarashitm commented 6 years ago

Hi @mattrpav , can you fix the checkstyle errors? you can run it via mvn checkstyle:check

mattrpav commented 6 years ago

@igarashitm yep.. fixing all that now, thanks.

mattrpav commented 6 years ago

@igarashitm these changes also improve the correctness of FieldAction processing in that FieldActions may return a different type than the original source type.. StringLength, for example. The InputField should be updated to be value=$integer_value fieldType=FieldType.INTEGER

mattrpav commented 6 years ago

Note: this solves #260 as well.

pure-bot[bot] commented 6 years ago

Pull request approved by @igarashitm - applying approved label