search

atlasmap-attic / atlasmap-runtime

AtlasMap runtime engine and design time services
http://atlasmap.io
Other
3 stars 8 forks source link

[atlas-core] allow combine for primitive types + fix Double and Date converter #267

Closed mmelko closed 6 years ago

mmelko commented 6 years ago

fix(atlas-core DoubleConverter) double to string converter fix(atlas-core DateConverter) hadne conversion of Long.MIN_VALUE Fixes #266 Fixes #268 Fixes #269

mmelko commented 6 years ago

@igarashitm I added also simple test but I had to create few dummy classes. It's not nice but it works. Is it ok or you would like to separate it into standalone class files.

igarashitm commented 6 years ago

@mmelko thanks for the contribution! can you try the mvn checkstyle:check and fix a few errors?

igarashitm commented 6 years ago

And a housekeeping thing, can you add a bit description for the issue in commit comment? That helps us to find it later by git log --grep. Here is the example

fix(atlas-core combine): Allow COMBINE for non String fields

Fixes: #266
pure-bot[bot] commented 6 years ago

Pull request approved by @igarashitm - applying approved label