atlasmap-attic / atlasmap-runtime

AtlasMap runtime engine and design time services
http://atlasmap.io
Other
3 stars 8 forks source link

Different level used for log and audit in BaseAtlasModule.processSeparateField(AtlasSession, Mapping, Field, Field) #270

Closed apupier closed 6 years ago

apupier commented 6 years ago

there is a warn and a log, which one should be used?

            LOG.warn(String.format("Separate requires zero or positive Index value to be set on outputField outputField.path=%s",
                    outputField.getPath()));
            addAudit(session, outputField.getDocId(),
                    String.format("Separate requires zero or positive Index value to be set on outputField outputField.path=%s",
                            outputField.getPath()),
 outputField.getPath(), AuditStatus.ERROR, null);
mattrpav commented 6 years ago

Logging, Audits and Validations weren't meant to be the same thing, so variance in 'level' betwen them isn't necessarily incorrect. Due to time constraints, the final behaviors were never finalized. See (#7)

igarashitm commented 6 years ago

duplicates #271