search

atlasmap-attic / atlasmap-ui

An Angular2 module for designing Atlasmap mapping definitions
Apache License 2.0
9 stars 8 forks source link

AOT compile error #113

Closed gashcrumb closed 6 years ago

gashcrumb commented 6 years ago

As I've been doing some dependency updates I keep running into this error periodically until I find the magic combination of versions to bring in. Am concerned that this could eventually be a problem.

screenshot 2017-10-18 08 10 13
gashcrumb commented 6 years ago

The main thing I'm wondering is does this type change in newer angular versions:

https://github.com/atlasmap/atlasmap-ui/blob/master/src/app/lib/atlasmap-data-mapper/components/modal.window.component.ts#L66

and:

https://github.com/atlasmap/atlasmap-ui/blob/master/src/app/lib/atlasmap-data-mapper/components/modal.window.component.ts#L74

And also, would it make sense to consider migrating to the ngx-bootstrap modal window?

gashcrumb commented 6 years ago

@igarashitm awesome! Does this then get automatically published to the npm repo?

igarashitm commented 6 years ago

@gashcrumb yep, 1.32.0-SNAPSHOT.20171018190510 has been published from CI :)