search

atlasmap-attic / atlasmap-ui

An Angular2 module for designing Atlasmap mapping definitions
Apache License 2.0
9 stars 8 forks source link

Typo in error message #86

Closed gashcrumb closed 7 years ago

gashcrumb commented 7 years ago

Think the error message to the right should be isn't supported. Also it shouldn't be 2 messages, and am not sure if we need to display both of those error alerts.

data mapper error msg

@dongniwang FYI

igarashitm commented 7 years ago

Actually this is an INFO message to be used in the validation result, wondering why it's showing as an ERROR

igarashitm commented 7 years ago

And the duplicate validation error is caused by atlasmap/atlasmap#127 I'm working on as a part of atlasmap/atlasmap#188

gashcrumb commented 7 years ago

@igarashitm ah, k, so this probably duplicates that issue then?

igarashitm commented 7 years ago

I think we'll need to fix that "is supported" thing at UI side after refactoring validation at runtime side, that INFO message shouldn't be displayed as an ERROR. Let's see after it's merged.

igarashitm commented 7 years ago

We still have a major bug #112 though, it should get a bit better, at least INFO message is no longer shown as an error.