search

atlasmap-attic / atlasmap-ui

An Angular2 module for designing Atlasmap mapping definitions
Apache License 2.0
9 stars 8 forks source link

Remove font-awesome and patternfly from src and resolve as dependency #91

Closed igarashitm closed 6 years ago

igarashitm commented 6 years ago

Right now it's in https://github.com/atlasmap/atlasmap-ui/tree/master/src/app/lib, should be removed and resolved at compile time

igarashitm commented 6 years ago

@gashcrumb got 404 for font-awesome and jquery while it seems fine for patternfly ... looks weird as I did same for all but it contains node_modules dir in the path for font-awesome and jquery, but not for patternfly. any idea?

[1] 17.10.12 11:57:44 404 GET /node_modules/jquery/dist/js/jquery.min.js
[1] 17.10.12 11:57:44 304 GET /bootstrap/dist/css/bootstrap.min.css
[1] 17.10.12 11:57:44 304 GET /patternfly/dist/css/patternfly.min.css
[1] 17.10.12 11:57:44 304 GET /patternfly/dist/css/patternfly-additions.min.css
[1] 17.10.12 11:57:44 404 GET /node_modules/font-awesome/dist/css/font-awesome.min.css
[1] 17.10.12 11:57:45 404 GET /node_modules/jquery/dist/js/jquery.min.js
[1] 17.10.12 11:57:45 404 GET /node_modules/font-awesome/dist/css/font-awesome.min.css
igarashitm commented 6 years ago

ugh OK, font-awesome doesn't have dist dir. will check those paths again.