search

atlassian-api / atlassian-python-api

Atlassian Python REST API wrapper
https://atlassian-python-api.readthedocs.io
Apache License 2.0
1.29k stars 644 forks source link

tests/mockup.py missing from the PyPi source tarball #1206

Closed WOnder93 closed 10 months ago

WOnder93 commented 11 months ago

The latest tarball doesn't contain the file, without which it is impossible to run the tests.

gonchik commented 11 months ago

@WOnder93 it's strange, as I use the standard mechanism of Github to generating tarball.

I have uploaded a new release, please use it

WOnder93 commented 11 months ago

Thanks, but I didn't mean the GitHub tarballs (those are fine), but the source tarballs on PyPI (https://pypi.org/project/atlassian-python-api/#files). The 3.40.0 tarball there is till missing the file.

gonchik commented 11 months ago

@WOnder93 noted

gonchik commented 11 months ago

Hi! on that commit extended package directory 8b90689c2bf9a0daf63cb4e8f7c404730707a443

gonchik commented 10 months ago

@WOnder93 now it should be ok

WOnder93 commented 10 months ago

Thanks, but this solution doesn't seem correct. Now the package installs a toplevel tests package in addition to atlassian, which may conflict with some other package and likely isn't what users expect. Basically, when someone installs this version from PyPI, now they will end up with a tests directory under site-packages and if they do import tests anywhere, they will get the atlassian-python-api's tests package.

After I did some digging, I believe the right way to fix it is to undo the respective changes from 8b90689c2bf9a0daf63cb4e8f7c404730707a443 and add recursive-include tests * to MANIFEST.in, so that the directory (and all its contents) is included in the source tarball, but not installed as a package.

gonchik commented 10 months ago

@WOnder93 could you send a PR please?

WOnder93 commented 10 months ago

Sure, opened #1215