search

atlassian-api / atlassian-python-api

Atlassian Python REST API wrapper
https://atlassian-python-api.readthedocs.io
Apache License 2.0
1.29k stars 643 forks source link

advanced_mode flag is not passed to underlying `request` method preventing handling of 429 rate limit #1241

Closed 2ps closed 9 months ago

2ps commented 9 months ago

several methods of atlassian.rest_client.AtlassianRestAPI, like the post method, do not propagate the advanced_mode flag to the underlying request method. Because that flag is not propagated to the underlying call, rate limit exceptions are thrown and graceful handling of a 429 status code by using the response headers is not possible.

Proposed fix: pass the advanced_mode flag passed into functions like post to the underlying request method.

gonchik commented 9 months ago

@2ps please share PR

Spacetown commented 9 months ago

It will be better to handle the 429 on our own, hiding the logic from the user. The user never wants to abort the script because of rate limits.

We should work on #904.

2ps commented 9 months ago

This can be closed, it is addressed in a merged PR.