search

atlassian-api / atlassian-python-api

Atlassian Python REST API wrapper
https://atlassian-python-api.readthedocs.io
Apache License 2.0
1.34k stars 661 forks source link

rest_client.py error on line 481 when values or keys are integers #1242

Open 2ps opened 1 year ago

2ps commented 1 year ago

We should use %, .format, or f-strings instead for situations when keys or values are integers, since + does not automatically type-convert for us.

Spacetown commented 1 year ago

I think that the user should provide the data with the correct types. There can be parameters which need to be integers.

2ps commented 1 year ago

@Spacetown This is in exception handling, I don't see how the user can specify which values are in the response json, although I am happy to hear suggestions.

2ps commented 1 year ago

https://github.com/atlassian-api/atlassian-python-api/pull/1244 addresses this issue.

2ps commented 1 year ago

@Spacetown @gonchik could I please get your review on this at your convenience?

Spacetown commented 1 year ago

Ok, for exception handling this can be done. Next time you should use a permalink instead of a line number without a link.