Closed 2ps closed 9 months ago
@2ps could wrap via str() instead of f-strings. Because it will break 2.7 compatibility
@2ps please use format in that situation please?
Apologies
@2ps please use format in that situation please?
Apologies for the late response, will do. That said, the setup.py file indicates that python2 isn't supported -- we may also want to update that to indicate support for python 2 and the eol'd python 2.7.
Patch coverage: 100.00%
and project coverage change: -0.02%
:warning:
Comparison is base (
176da86
) 34.47% compared to head (b42b065
) 34.45%. Report is 2 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks
if keys or values in the response json are
int
s, thek + ": " + v
expression will fail because anint
is not astr
. In order to avoid this, we can either use%
-formatting,.format
formatting, or f-strings. I chose f-strings for usability, but regardless of which direction, the issue should be addressed one of those ways.addresses #1242