Jira: Rename tempo_4_timesheets_find_worklogs params (#1273)

atlassian-api / atlassian-python-api

Atlassian Python REST API wrapper

https://atlassian-python-api.readthedocs.io

Apache License 2.0

1.34k stars 661 forks source link

Jira: Rename tempo_4_timesheets_find_worklogs params (#1273) #1275

Closed anttipalsola closed 10 months ago

anttipalsola commented 10 months ago

To fix #1273, rename the parameters of Jira.tempo_4_timesheets_find_worklogs as follows:

from → date_from
- from is a keyword, so it cannot be used as a parameter name
- date_from is also used in Jira.tempo_timesheets_get_worklogs
- See https://github.com/atlassian-api/atlassian-python-api/issues/1273
to → date_to
- renamed for consistency with date_from

codecov-commenter commented 10 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (726e969) 34.47% compared to head (946c2d4) 34.46%.

Files	Patch %	Lines
atlassian/jira.py	20.00%	4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1275 +/- ## ========================================== - Coverage 34.47% 34.46% -0.02% ========================================== Files 45 45 Lines 8173 8177 +4 Branches 1131 1133 +2 ========================================== Hits 2818 2818 - Misses 5241 5245 +4 Partials 114 114 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.