revert misuse of programmatical approach in setup.py

atlassian-api / atlassian-python-api

Atlassian Python REST API wrapper

https://atlassian-python-api.readthedocs.io

Apache License 2.0

1.29k stars 642 forks source link

revert misuse of programmatical approach in setup.py #1303

Closed FCamborda closed 5 months ago

FCamborda commented 5 months ago

setup.py was ditched a long time ago and newer PEPs recommend using setup.cfg or pyproject.toml

The last changes in setup.py created a misdirected dependency between requirements.txt and setup.py, which included an optional dependency that is causing problems upstreams.

This PR merely reverts those changes in favour for the old already-working setup.

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1045f57) 34.49% compared to head (21993fd) 34.49%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1303 +/- ## ======================================= Coverage 34.49% 34.49% ======================================= Files 45 45 Lines 8257 8257 Branches 1146 1146 ======================================= Hits 2848 2848 Misses 5295 5295 Partials 114 114 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.