atlassian-api / atlassian-python-api

Atlassian Python REST API wrapper
https://atlassian-python-api.readthedocs.io
Apache License 2.0
1.29k stars 642 forks source link

[Bitbucket] Fixed Pull Requests Activities path #1326

Closed roboqo closed 5 months ago

roboqo commented 5 months ago

Non existing API endpoint was used in the latest version, so this PR fixes that.

codecov-commenter commented 5 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (26f450e) 34.35% compared to head (94d8475) 34.35%.

Files Patch % Lines
atlassian/bitbucket/__init__.py 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1326 +/- ## ======================================= Coverage 34.35% 34.35% ======================================= Files 45 45 Lines 8302 8302 Branches 1158 1158 ======================================= Hits 2852 2852 Misses 5336 5336 Partials 114 114 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SkylerSalvato commented 4 months ago

@roboqo @gonchik

Hi, my team uses this with the Bitbucket Server REST API, and the endpoint actually still uses activities. Would it be possible to implement this change specifically for Bitbucket Cloud, similar to the following?

https://github.com/roboqo/atlassian-python-api/blob/94d8475a445a5890258ff3049c149a8a7faa7ca4/atlassian/bitbucket/__init__.py#L1552-L1556

SkylerSalvato commented 4 months ago

See my proposed change here: #1336

taniajtaniaj commented 4 months ago

Hi, This change breaks our system. Our bitbucket supports "activities" but not "activity" ...

SkylerSalvato commented 4 months ago

Hi, This change breaks our system. Our bitbucket supports "activities" but not "activity" ...

I created PR #1336 that fixes this, and it was merged, but the version has not been released yet. Until it is released you should be able to pin to the last version (atlassian-python-api==3.41.9).

gonchik commented 4 months ago

@roboqo @taniajtaniaj I will publish a new release in a few hours

taniajtaniaj commented 4 months ago

thanks a lot! very much appreciated!!