search

atlassian-api / atlassian-python-api

Atlassian Python REST API wrapper
https://atlassian-python-api.readthedocs.io
Apache License 2.0
1.29k stars 642 forks source link

[Jira] fix paginated projects retrieving #1343

Closed ebaschiera closed 3 months ago

ebaschiera commented 4 months ago

Fixes #1310

Spacetown commented 3 months ago

This looks like a refactoring only. The logic is still the same.

Spacetown commented 3 months ago

@gonchik Are you really sure that this fixes the issue? The loop is only restructured using variables but is still doing the same thing.

gonchik commented 3 months ago

@Spacetown hm, it's automatically closed that issue. I just merged iterator.

correct, fix must go wrapping startAt parameter. https://developer.atlassian.com/cloud/jira/platform/rest/v3/api-group-projects/#api-rest-api-3-project-search-get

Spacetown commented 3 months ago

Yes, the iterative was only refactored. In the closed issue I linked a Branch where the same workaround as for the cloud is added. I raise a PR and you can check it.

Edit: Now I see it, also the project variable is modified now in the loop. In the original version this wasn't done.