atlassian-api / atlassian-python-api

Atlassian Python REST API wrapper
https://atlassian-python-api.readthedocs.io
Apache License 2.0
1.29k stars 642 forks source link

[Confluence] Expand parameter addition for get_draft_page_by_id #1388

Closed austinmh12 closed 1 month ago

austinmh12 commented 1 month ago

get_draft_page_by_id calls the same endpoint as get_page_by_id but with the status defaulted to draft. Updated the underlying function to just forward the params to get_page_by_id which allows the expand and version parameter to be passed as well, though I only added the expand parameter to get_draft_page_by_id since the versioning is a bit different than the standard page versioning.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 34.07%. Comparing base (413524b) to head (b714eed). Report is 9 commits behind head on master.

Files Patch % Lines
atlassian/confluence.py 50.00% 1 Missing :warning:
atlassian/jira.py 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1388 +/- ## ========================================== - Coverage 34.14% 34.07% -0.07% ========================================== Files 46 46 Lines 8444 8472 +28 Branches 1190 1195 +5 ========================================== + Hits 2883 2887 +4 - Misses 5446 5469 +23 - Partials 115 116 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.