atlassian-api / atlassian-python-api

Atlassian Python REST API wrapper
https://atlassian-python-api.readthedocs.io
Apache License 2.0
1.36k stars 664 forks source link

black formatting in multiple versions of python #1420

Open bandophahita opened 5 months ago

bandophahita commented 5 months ago

I'm currently working on a draft PR to add type hint annotations and I noticed black installs an older version in python3.6 & python3.7. This is causing inconsistent results in tox due to changes in formatting between older and newer versions of black.

See: https://github.com/atlassian-api/atlassian-python-api/actions/runs/9490554332 for the results.

There are a couple of options I can see:

My question for the maintainers; what do you suggest?

gonchik commented 5 months ago

@bandophahita based on the stats : https://pypistats.org/packages/atlassian-python-api

image

time to skip python2 version with proper announce.

bandophahita commented 5 months ago

How about dropping unsupported python3 versions?
3.7 was end-of-life last year. 3.6 ended in 2021. https://devguide.python.org/versions/

image
gonchik commented 5 months ago

@bandophahita Indeed, let me adjust it.