black formatting in multiple versions of python

bandophahita commented 2 weeks ago

I'm currently working on a draft PR to add type hint annotations and I noticed black installs an older version in python3.6 & python3.7. This is causing inconsistent results in tox due to changes in formatting between older and newer versions of black.

See: https://github.com/atlassian-api/atlassian-python-api/actions/runs/9490554332 for the results.

There are a couple of options I can see:

force black to an older version in all supported versions of python
have black only check in a subset or even singular version of python.
- this will be tricky as the current testing is done in tox then in docker; for as long as the package supports older (no longer supported) versions of python.
drop support for older python versions.
- seems above my paygrade to suggest, but would eliminate a bunch of other support issues
~~add # fmt: skip in the places where versions of black differ~~ (this does not appear to work)

My question for the maintainers; what do you suggest?

gonchik commented 2 weeks ago

@bandophahita based on the stats : https://pypistats.org/packages/atlassian-python-api

time to skip python2 version with proper announce.

bandophahita commented 2 weeks ago

How about dropping unsupported python3 versions?
3.7 was end-of-life last year. 3.6 ended in 2021. https://devguide.python.org/versions/

gonchik commented 2 weeks ago

@bandophahita Indeed, let me adjust it.

atlassian-api / atlassian-python-api

black formatting in multiple versions of python #1420