atlassian-labs / atlassian-slack-integration-server

Slack plugins for Jira, Confluence and Bitbucket Server
Apache License 2.0
32 stars 25 forks source link

Flagged in the Confluence DC CDN Health Checks due to deprecated code #325

Open marcus-si opened 1 year ago

marcus-si commented 1 year ago

Slack integration plugin for Confluence DC is flagged in the CDN Health Checks due to deprecated code. Screenshot 2023-11-03 at 16 58 32

After dug into the source codes of atlassian-plugins-webresource and this plugin, the cause is that the plugin has used com.atlassian.confluence.plugin.descriptor.web.conditions.user.UserLoggedInCondition. atlassian-plugins-webresource now requires all conditions to implement com.atlassian.plugin.webresource.condition.UrlReadingCondition , and otherwise it will mark a condition as legacy.

To fix the issue, we need to use com.atlassian.confluence.plugin.descriptor.web.urlreadingconditions.UserLoggedInUrlReadingCondition instead of com.atlassian.confluence.plugin.descriptor.web.conditions.user.UserLoggedInCondition .