Bitbucket PR notifications for tasks are misleading

mkgl commented 3 years ago

Hi, 👋

When Alice adds a task on Bob's PR, and he ticks it as completed, the resulting notification indicates:

💬 Alice edited a comment on pull request ... feature/foo → master in

So both the "actor" and activity are misleading. I'm unsure about the support on Bitbucket side:

on the one hand, tasks seem to be treated as comments, as per this doc page on webhooks (if the app is indeed webhook-based): https://confluence.atlassian.com/bitbucketserver/managing-webhooks-in-bitbucket-server-938025878.html
on the other hand, in Slack integration settings, we can select PR events such as Task created / updated / resolved.

Any tweak that could be done to differentiate tasks? (or any pointer I could use?) Cheers,

PS: glad there's an open-source repo for that. :)

mvlasovatl commented 2 years ago

Hey @mkgl ! I failed to reproduce the issue with latest version of the plugin - 4.0.2. Tasks related code was refactored a bit as part of Bitbucket 8 compatibility effort, so it could inadvertently fix your issue as well. Could you confirm it?

mkgl commented 2 years ago

Hi @mvlasovatl, I can confirm both the actor and the activity are correct now, awesome! Thanks a lot for the heads-up!

✔️ Alice resolved a task in pull request ... feature/foo → main in ...

atlassian-labs / atlassian-slack-integration-server

Bitbucket PR notifications for tasks are misleading #68