Fix no-empty-styled-expression rule that's linting false positives - Githubissues

atlassian-labs / compiled

A familiar and performant compile time CSS-in-JS library for React.

https://compiledcssinjs.com

Apache License 2.0

1.99k stars 67 forks source link

Fix no-empty-styled-expression rule that's linting false positives #1590

Closed zerosicx closed 11 months ago

zerosicx commented 11 months ago

Cause of the bug is checking the CallExpression itself for the styled import reference, rather than the MemberExpression.
- This would result in checking the Program level on direct function calls (false positive) along with triggering the lint rule within nested empty function calls inside a styled TemplateExpression.
Fix: checking the import reference from within the MemberExpression (much like the no-styled-tag-template rule -- this fix was implemented as this solution makes use of one of the utility functions in that rule).
Added edge test cases from the false positives found on JFE

changeset-bot[bot] commented 11 months ago

🦋 Changeset detected

Latest commit: 7b2cd4ecba862e039593a5b10ba3add3e97a7c4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ----------------------- | ----- | | @compiled/eslint-plugin | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

liamqma commented 11 months ago

It seems the diffs include more than your commits, which makes it a tad hard to know what's actually in the PR.

dddlr commented 10 months ago

looks good!