search

atlassian-labs / compiled

A familiar and performant compile time CSS-in-JS library for React.
https://compiledcssinjs.com
Apache License 2.0
1.99k stars 67 forks source link

Add missing typecheck command #1613

Closed itsdouges closed 9 months ago

itsdouges commented 9 months ago

This pull request adds a typecheck command and adds it to the CI run. It also fixes a ton of violations. One thing I haven't reconciled yet is how to typecheck the project references with the same command, any ideas let me know! Perhaps we just exclude packages and assume they're typechecked when generating the types?...

changeset-bot[bot] commented 9 months ago

⚠️ No Changeset found

Latest commit: a8ead2d370de0d3e49fb7f31968793233ca8c006

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dddlr commented 9 months ago

Ooh thanks for the fix

LGTM assuming that skipLibCheck is removed and you get green builds

itsdouges commented 9 months ago

Needs more work.