Closed dddlr closed 4 months ago
Latest commit: 7dabece2823a2150e247be7fd8902fb44797f393
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Nice one @dddlr I'd consider porting the test across here as well. We based most of ours off the examples on MDN.
Fixes #1650, where quotes are incorrectly added around the value in situations like
content: url(...)
andcontent: counter(...)
Thanks to @mattcompiles for suggesting this approach to fixing the bug.
Based on https://github.com/vanilla-extract-css/vanilla-extract/blob/a623c1c65a543afcedb9feb30a7fe20452b99a95/packages/css/src/transformCss.ts#L266
For the curious:
content
property: https://github.com/emotion-js/emotion/blob/f4640f6a7cbe77f790e07706b287cb29342fd0ea/packages/serialize/src/index.js#L83content
property (and I think styled-components v3 too)